Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: Remove tracing code #2420

Merged
merged 4 commits into from
Jun 6, 2022
Merged

tracing: Remove tracing code #2420

merged 4 commits into from
Jun 6, 2022

Conversation

mastercactapus
Copy link
Member

Description:
This PR removes unmaintained tracing code and dependencies. The following flags have been deprecated and no longer function:

  • jaeger-endpoint
  • jaeger-agent-endpoint
  • stackdriver-project-id
  • tracing-cluster-name
  • tracing-pod-namespace
  • tracing-pod-name
  • tracing-container-name
  • tracing-node-name
  • tracing-probability

Using the flags will not prevent GoAlert from starting, but a warning will be printed.

Which issue(s) this PR fixes:
Closes #2158

Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mastercactapus mastercactapus merged commit 094d4e2 into master Jun 6, 2022
@mastercactapus mastercactapus deleted the remove-tracing-code branch June 6, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debt: remove unmaintained tracing code
3 participants