Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/rotations: convert RotationUserList to typescript #2675

Merged
merged 1 commit into from
Nov 28, 2022
Merged

ui/rotations: convert RotationUserList to typescript #2675

merged 1 commit into from
Nov 28, 2022

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Nov 2, 2022 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Convert the RotationUserList component to Typescript.

Which issue(s) this PR fixes:
Part of #2318

@KatieMSB @nataliekorzh
convert to ts
1a1f7e8 
Co-authored-by: nataliekorzh <nkorzh@oberlin.edu>
@KatieMSB KatieMSB mentioned this pull request Nov 2, 2022
Open
@mastercactapus mastercactapus merged commit d33703a into master Nov 28, 2022
@mastercactapus mastercactapus deleted the rotation-user-list-typescript branch November 28, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @Forfold