user/cm: cleanup unverified contact methods #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercactapus
requested changes
Jan 4, 2023
migrate/migrations/20221228092646-add-pending-to-contact-methods.sql
Outdated
Show resolved
Hide resolved
migrate/migrations/20221228092646-add-pending-to-contact-methods.sql
Outdated
Show resolved
Hide resolved
migrate/migrations/20221228092646-add-pending-to-contact-methods.sql
Outdated
Show resolved
Hide resolved
migrate/migrations/20221228092646-add-pending-to-contact-methods.sql
Outdated
Show resolved
Hide resolved
migrate/migrations/20221228092646-add-pending-to-contact-methods.sql
Outdated
Show resolved
Hide resolved
migrate/migrations/20221228092646-add-pending-to-contact-methods.sql
Outdated
Show resolved
Hide resolved
- Refactored the migration - Refactored the verifymanager test
KatieMSB
requested changes
Jan 6, 2023
KatieMSB
previously approved these changes
Jan 11, 2023
mastercactapus
requested changes
Feb 2, 2023
migrate/migrations/20221228092646-add-pending-to-contact-methods.sql
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
KatieMSB
previously approved these changes
Mar 20, 2023
KatieMSB
previously approved these changes
Mar 20, 2023
mastercactapus
previously approved these changes
Mar 20, 2023
|
@mastercactapus @KatieMSB had to remake the db-schema to fix build issues. |
…rt into 2727-cleanup-unverified-cms
mastercactapus
approved these changes
Mar 20, 2023
KatieMSB
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Unverified contact methods will be automatically removed when the verification code expires. This prevents contact methods that may have been created by mistake or were otherwise orphaned from hanging around in the system.
Which issue(s) this PR fixes:
Fixes #2727
Screenshots:
Describe any introduced user-facing changes:
A UI message is displayed on unverified contact methods.
Describe any introduced API changes:
Added a
pendingproperty to theUserContactMethod.Additional Info:
pendingfield to theuser_contact_methodstable. When a contact method is created it is defaulted to true. Once the contact method is verified it will be set to false via a database trigger on theuser_contact_methods.disabledfield. This field can be used going forward to know if a contact method has been previously verified.pendingvalue set to false therefore considering them to have been verified at some point and the system will not remove them.