Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: hardening some of the dev tools and a few places in app code #3115

Merged
merged 5 commits into from
Jun 22, 2023
Merged

dev: hardening some of the dev tools and a few places in app code #3115

merged 5 commits into from
Jun 22, 2023

Conversation

mastercactapus
Copy link
Member

Description:

  • limiting int parsing to 32 bits (prevents overflow on 32-bit systems)
  • remove the oauth page code in mockslack since it's unused
  • limiting procwrap's extra args to the experimental flag feature
  • updated the query_param tools in the UI to use the browser's URL parser instead of regex

allending313
allending313 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@allending313 allending313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mastercactapus mastercactapus merged commit dc0e70f into master Jun 22, 2023
@mastercactapus mastercactapus deleted the hardening-1 branch June 22, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieMSB KatieMSB KatieMSB approved these changes

@allending313 allending313 allending313 approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @KatieMSB @allending313