Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extending maintenance allowance through API #3160

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

theautoroboto
Copy link
Contributor

@theautoroboto theautoroboto commented Jul 11, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Extending maximum maintenance mode from 8 hours to 24 hours. We also want to allow a 5 minute grace period for clock drift.

Which issue(s) this PR fixes:
N/A

Out of Scope:
N/A

Screenshots:
N/A

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:
Nothing new introduced, but this does alter the maximum amount of time a service can be added to maintenance mode

Additional Info:
none

mastercactapus
mastercactapus previously approved these changes Jul 11, 2023
Forfold
Forfold previously approved these changes Jul 11, 2023
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

though the comment above the function looks wrong- probably a copy paste. If you don't mind could you update it to something like

// Normalize will validate and 'normalize' the Service -- such as setting the minimum duration to 0.

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🎉

@mastercactapus mastercactapus merged commit 142e8f9 into target:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants