Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/components: Convert toolBarAction to ts #3233

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

leyasalazar
Copy link
Collaborator

@leyasalazar leyasalazar commented Aug 16, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of converting javascript files to typescript. Converted ToolBarAction file.

Which issue(s) this PR fixes:
Part of #2318

web/src/app/main/components/ToolbarAction.tsx Outdated Show resolved Hide resolved
web/src/app/main/components/ToolbarAction.tsx Show resolved Hide resolved
web/src/app/main/components/ToolbarAction.tsx Outdated Show resolved Hide resolved
web/src/app/main/components/ToolbarAction.tsx Outdated Show resolved Hide resolved
web/src/app/main/components/ToolbarAction.tsx Outdated Show resolved Hide resolved
@mastercactapus mastercactapus merged commit d38cf0a into master Aug 21, 2023
6 checks passed
@mastercactapus mastercactapus deleted the convert-ts-ToolbarAction branch August 21, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants