Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/components: Convert NewUserSetUp to ts #3242

Merged
merged 6 commits into from
Aug 31, 2023
Merged

Conversation

leyasalazar
Copy link
Collaborator

@leyasalazar leyasalazar commented Aug 21, 2023

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of converting javascript files to typescript. Converted NewUserSetUp file.

Which issue(s) this PR fixes:
Part of #2318

cmarquis
cmarquis previously approved these changes Aug 28, 2023
@leyasalazar leyasalazar merged commit c7d8bdf into master Aug 31, 2023
6 checks passed
@leyasalazar leyasalazar deleted the convert-ts-NewUserSetup branch August 31, 2023 19:20
1ddo pushed a commit to 1ddo/goalert that referenced this pull request Sep 7, 2023
* convert NewUserSetUp to ts

* updated userId type to string

* changed to single  quotation
allending313 pushed a commit that referenced this pull request Sep 13, 2023
* convert NewUserSetUp to ts

* updated userId type to string

* changed to single  quotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants