-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3007 api key UI #3324
3007 api key UI #3324
Conversation
…into 3007-api-key-ui update from graphql-api-keys
…o Create Dialog and Delete and Edit Dialog to the Drawer Dialog
…ed style to sx field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things. When using the Create API Key dialog, I'm seeing the error:
useControlled.js:35 MUI: A component is changing the default value state of an uncontrolled Autocomplete after being initialized. To suppress this warning opt to use a controlled Autocomplete.
After submitting when viewing the API key to copy, I get the error:
<p> cannot appear as a descendant of <p>.
Also, can we fix the following:
- Decrease the max-width on the copy API key dialog by a level
- Update "No Data Available" to "No Results"
- Match the whitespace for the header and the no results text
- Have list go to full width of card so there's no margin when hovering/selected:
- Center time text in list, or add a secondary
<OtherActions />
for editing and deleting, to match other list pages:
- Format delete dialog with Cancel, Submit, and Title Case "Delete API Key":
- The transition throws an error when selecting/deselecting a key:
Failed prop type: Invalid prop `in` of type `object` supplied to `ForwardRef(Fade2)`, expected `boolean`.
I can work on the above fixes ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimistic updates on creating and deleting would be nice, but it's looking good to go 👍
make check
to catch common errors. Fixed any that came up.Description:
Adds a page for API key creation and deletion. When a key is created, it can be viewed and copied only until the dialog is closed. After that, a new one must be created if lost.
Use the command
make start EXPERIMENTAL=gql-api-keys
to functionally test.Which issue(s) this PR fixes:
Out of Scope:
Screenshots:
Describe any introduced user-facing changes:
Describe any introduced API changes:
Additional Info: