Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statusmgr: expire status subscriptions after 7 days #3610

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

mastercactapus
Copy link
Member

Description:
This PR updates the statusmgr to expire/delete alert status subscriptions after 7 days of inactivity.

Which issue(s) this PR fixes:
Closes #3245

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:
N/A

Additional Info:
A new updated_at column was added, and the engine will now update the timestamp each time a status update is processed. Rows where updated_at is more than 7 days old are deleted/cleaned up, no longer requiring processing and no longer resulting in update messages.

If an alert escalates and a new message is sent, a new subscription would be created and behave as it does today. Effectively this means you may receive updates to a notification alert for up to 7 days as an absolute maximum.

NOTE: Existing status subscriptions will be set to the current time, so the 7 day maximum will take effect in full 7 days after this update is deployed.

tony-tvu
tony-tvu previously approved these changes Jan 19, 2024
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Forfold Forfold merged commit 07d7b8b into master Jan 24, 2024
7 checks passed
@Forfold Forfold deleted the expire-status-updates branch January 24, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status Updates for Closed Alerts Lack Max-Age
3 participants