This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Actually support Go #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go sets GOPATH in setup hooks, *not* shellHook. This means the current behavior is broken. This failing test accurately shows that.
grahamc
force-pushed
the
bug23/actual-go-support
branch
from
a74caf9
to
fe56c24
Compare
|
tested locally and confirmed to work equivalent to plain |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75 implemented support for shellHooks, but ... oops: Go doesn't use shellHooks to setup GOPATH.
This code monkeypatches much sooner: https://github.com/NixOS/nixpkgs/blob/22a765d0da7070311e5b8c2bb29fa496c833dae5/pkgs/stdenv/generic/setup.sh#L238-L284
and correctly supports GOPATH.
It also fixes a bit of an annoying bug where an appended variable would be appended, including a delimiter, even if the variable was empty before: 664727a
cc @mmlb who found and helped debug this problem. (and tested it fixed it!)