fix: resolved design flaw in wallet_ffi library #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StriderDM
force-pushed
the
ffi_design_flaw_fix
branch
2 times, most recently
from
158e652
to
662cf8d
Compare
This was referenced Sep 2, 2021
philipr-za
reviewed
Sep 3, 2021
Exposed TariTransactionKernel instead of TariExcess, TariExcessSignature and TariExcessPublicNonce. This was done as they are all referring to fields from the same object and also to reduce the amount of wrapper classes needs on the other side of the FFI boundary. Added accessor methods to retrieve data from the opaque pointer for TariTransactionKernel and return the data as a type (in this instance a cstring) which can safely cross the FFI boundary. Updated library header. Updated rust tests. Updated cucumber tests. Updated comments. Incremented library version. Fix typo Fix duplicate line
StriderDM
force-pushed
the
ffi_design_flaw_fix
branch
from
662cf8d
to
cbcb04e
Compare
stringhandler
approved these changes
Sep 3, 2021
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
Description Exposed TariTransactionKernel instead of TariExcess, TariExcessSignature and TariExcessPublicNonce. This was done as they are all referring to fields from the same object and also to reduce the amount of wrapper classes needs on the other side of the FFI boundary. Added accessor methods to retrieve data from the opaque pointer for TariTransactionKernel and return the data as a type (in this instance a cstring) which can safely cross the FFI boundary. Updated library header. Updated rust tests. Updated cucumber tests. Updated comments. Incremented library version. Merge tari-project#3275 first. Motivation and Context --- How Has This Been Tested? cargo test --all --all-features nvm use v12.22.6 && ./node_modules/.bin/cucumber-js features/WalletFFI.feature 
aviator-app bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
Description --- Include vendored openssl library when not building ffi wallet library. Exclude vendored openssl library when building ffi wallet library as it needs to be cross compiled for mobile which is done in mobile_build.sh. Merge #3285 first. We had to do the same for sqlite here: #3073 Motivation and Context --- Current:  This PR:  [mobile_build_logs.zip](https://github.com/tari-project/tari/files/7104686/mobile_build_logs.zip) How Has This Been Tested? --- cargo test --all --all-features nvm use v12.22.6 && ./node_modules/.bin/cucumber-js features/WalletFFI.feature sh mobile_build.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposed TariTransactionKernel instead of TariExcess, TariExcessSignature and TariExcessPublicNonce. This was done as they are all referring to fields from the same object and also to reduce the amount of wrapper classes needs on the other side of the FFI boundary.
Added accessor methods to retrieve data from the opaque pointer for TariTransactionKernel and return the data as a type (in this instance a cstring) which can safely cross the FFI boundary.
Updated library header.
Updated rust tests.
Updated cucumber tests.
Updated comments.
Incremented library version.
Merge #3275 first.
Motivation and Context
How Has This Been Tested?
cargo test --all --all-features
nvm use v12.22.6 && ./node_modules/.bin/cucumber-js features/WalletFFI.feature