Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node should verify DHT message field "stored_at" #3412

Closed
SWvheerden opened this issue Oct 4, 2021 · 0 comments · Fixed by #3444
Closed

Node should verify DHT message field "stored_at" #3412

SWvheerden opened this issue Oct 4, 2021 · 0 comments · Fixed by #3444

Comments

@SWvheerden
Copy link
Collaborator

A node should verify and add some checking to the "stored_at" field of a SAF message and not just blindly use this as the "LastSafMessageReceived" field as this can cause a node to poison its own "LastSafMessageReceived" so that it never receives any SAF messages again.
sdbondi added a commit to sdbondi/tari that referenced this issue Oct 11, 2021
@sdbondi
fix: check SAF message inflight and check stored_at is in past
6c6544a 
- Keeps track of inflight SAF requests and only accepts responses for
  requests that are inflight
- Checks that `stored_at` is in the past
- Fixes tari-project#3412, 3410
sdbondi added a commit to sdbondi/tari that referenced this issue Oct 11, 2021
@sdbondi
fix: check SAF message inflight and check stored_at is in past
04fb66b 
- Keeps track of inflight SAF requests and only accepts responses for
  requests that are inflight
- Checks that `stored_at` is in the past
- Fixes tari-project#3412, 3410
@sdbondi sdbondi mentioned this issue Oct 11, 2021
Merged
sdbondi added a commit to sdbondi/tari that referenced this issue Oct 11, 2021
@sdbondi
fix: check SAF message inflight and check stored_at is in past
365f109 
- Keeps track of inflight SAF requests and only accepts responses for
  requests that are inflight
- Checks that `stored_at` is in the past
- Fixes tari-project#3412, 3410
aviator-app bot pushed a commit to SWvheerden/tari that referenced this issue Oct 24, 2021
@sdbondi
fix: check SAF message inflight and check stored_at is in past (tari-…
fbf8eb8 
…project#3444)

Description
---
- Keeps track of inflight SAF requests and only accepts responses for
  requests that are inflight
- Checks that `stored_at` is in the past
- Fixes tari-project#3412, tari-project#3410 

Motivation and Context
---
See tari-project#3412, tari-project#3410

How Has This Been Tested?
---
- New/existing unit/integration tests
- memorynet
- Manually
@delta1 delta1 closed this as completed Jan 26, 2022
sdbondi added a commit to sdbondi/tari that referenced this issue Feb 3, 2022
@sdbondi
fix: check SAF message stored_at is not in the future
b516fe0 
Fixes tari-project#3412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check SAF message inflight and check stored_at is in past sdbondi/tari
2 participants
@delta1 @SWvheerden