fix: fix cucumber test for standard recovery #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent fix to a major bug in the key manager that meant branching wasn’t being used broke the `Multiple Wallet recovery from seed node` cucumber test. This was because the test was trying to recover coinbases outputs whose keys are from a different branch in the key manager. This PR fixes the `Wallet recovery with connected base node staying online` cucumber test to test recovering conventional outputs and marks `Wallet recovery with connected base node staying online` and `As a client I want to be able to restore my ffi wallet from seed words`as broken. They will be addressed by the team soon.
delta1
approved these changes
Jan 26, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 31, 2022
* development: (29 commits) feat(base-node): add base node prometheus metrics (tari-project#3773) fix(ffi): mut pointers should be const (tari-project#3775) chore: update launchpad for dibbler (tari-project#3769) v0.27.3 fix(ffi): missing param in header.h (tari-project#3774) v0.27.2 v0.27.2 fix(ffi): fix bad access (tari-project#3772) chore(collectibles): fix eslint v0.27.1 fix(ffi): fix null pointer assignment in import_utxo (tari-project#3770) fix(validators): check input metadata matches spending output (tari-project#3761) v0.27.0 feat(ffi)!: Add commitment_signature_create and destroy (tari-project#3768) feat(ffi)!: add features, metadata_signature and sender_offset_public_key to import_utxo (tari-project#3767) feat(explorer): better view on mempool (tari-project#3763) feat: update the available balance in console wallet (tari-project#3760) chore: reclassify very long log message (tari-project#3752) fix: fix cucumber test for standard recovery (tari-project#3757) style: format with prettier (same settings as in integration tests) (tari-project#3756) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent fix to a major bug in the key manager that meant branching wasn’t being used broke the
Multiple Wallet recovery from seed nodecucumber test. This was because the test was trying to recover coinbases outputs whose keys are from a different branch in the key manager.This PR fixes the
Wallet recovery with connected base node staying onlinecucumber test to test recovering conventional outputs and marksWallet recovery with connected base node staying onlineandAs a client I want to be able to restore my ffi wallet from seed wordsas broken. They will be addressed by the team soon.