fix: refactor incorrect cucumber test on burn funds via cli #4679
Conversation
…21/tari into ja_add_burn_funds_on_wallet
…21/tari into ja_add_burn_funds_on_wallet
…21/tari into ja_add_burn_funds_on_wallet
jorgeantonio21
requested review from
stringhandler,
hansieodendaal and
sdbondi
There was a problem hiding this comment.
Please see the comments below. The exact amounts used in the comments are not that important, but the principle is. I think the desired behaviour should be that we can create a burn transaction that utilizes all UTXOs in the wallet expecting a change amount just smaller than the smallest UTXO.
| Then I have mining node MINER_B mines 10 blocks | ||
| Then I get balance of wallet WALLET_A is at least 10000000000 uT via command line | ||
| When I wait for wallet WALLET to have at least 221552530060 uT | ||
| When I create a burn transaction of 201552500000 uT from WALLET via command line |
There was a problem hiding this comment.
This line currently does not spend all UTXOs in the wallet, but it shoud.
The average coinbase for the 1st 12 blocks is 18 462 710 838 uT. This amount should be large enough to utilize all available UTXOs in the transaction with expected change less than one coinbase worth, for example
221 552 530 060 uT - 205 089 819 222 uT = 16 462 710 838 uT. This will result in an empty wallet until the change UTXO is received.
| When I create a burn transaction of 201552500000 uT from WALLET via command line | |
| When I create a burn transaction of 205089819222 uT from WALLET via command line | |
| And I restart wallet WALLET | |
| Then wallet WALLET detects all transactions are at least Broadcast | |
| Then I wait for wallet WALLET to have less than 1 uT |
We can also restart the wallet here as waiting for the change UTXO to be received and confirmed does not need to be via the command line
| When I create a burn transaction of 201552500000 uT from WALLET via command line | ||
| When I mine 5 blocks on BASE | ||
| Then all nodes are at height 20 | ||
| # Then I wait for wallet WALLET to have at least 100 uT |
There was a problem hiding this comment.
| # Then I wait for wallet WALLET to have at least 100 uT | |
| Then I wait for wallet WALLET to have at least 100 uT |
This line is important to ensure the wallet received the change UTXO (worth 16 462 710 838 uT in this example)
| When I mine 5 blocks on BASE | ||
| Then all nodes are at height 20 | ||
| # Then I wait for wallet WALLET to have at least 100 uT | ||
| Then I get balance of wallet WALLET is at most 18462621580 uT via command line |
There was a problem hiding this comment.
| Then I get balance of wallet WALLET is at most 18462621580 uT via command line | |
| Then I get balance of wallet WALLET is at most 16462710838 uT via command line |
| And mining node MINER_A mines 15 blocks | ||
| And I have wallet WALLET connected to base node BASE | ||
| And I have mining node MINER connected to base node BASE and wallet WALLET | ||
| And mining node MINER mines 12 blocks |
There was a problem hiding this comment.
You could probably mine fewer blocks to make the calculations easier
Description
Refactor previously incorrect cucumber for burn funds via cli test.
Motivation and Context
PR #4655 introduced a specific cucumber for testing burn funds via cli. This test was incorrectly designed. This PR addresses the situation.
How Has This Been Tested?
Cucumber