Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resize transaction tab windows #5290

Merged
merged 3 commits into from
Apr 5, 2023
Merged

fix: resize transaction tab windows #5290

merged 3 commits into from
Apr 5, 2023

Conversation

CjS77
Copy link
Collaborator

@CjS77 CjS77 commented Apr 5, 2023

PR #4942 added a row to the tx detail view, but did not increase the size of the box. As a result, the maturity is cut off.

This PR makes the detail box one row wider, and adjusts the minimum size of the tx box to be 8 (this is the absolute minimum -- accounting for headers and one each of pending and completed txs).

Fixes #5289

Tari Console Wallet────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Transactions │ Send │ Receive │ Contacts │ Network │ Events │ Log │ Notifications                                                 │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
┌Balance────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│Available: 0 µT (Time Locked: 0 µT)                              Pending Incoming: 0 µT           Pending Outgoing: 0 µT           │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
 Up↑/Down↓ select Tx (C) cancel selected pending Txs (A) show/hide mining (R) rebroadcast Txs (Esc) exit list
┌Completed (T)ransactions (0) ──────────────────────────────────────────────────────────────────────────────────────────────────────┐
│   Source/Destination Address                                         Amount/Token      Mined At (Local)    Status                 │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
┌Transaction Details────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│TxID:                                                                                                                              │
│Source Address:                                                                                                                    │
│Destination address:                                                                                                               │
│Direction:                                                                                                                         │
│Amount:                                                                                                                            │
│Fee:                                                                                                                               │
│Status:                                                                                                                            │
│Message:                                                                                                                           │
│Mined At (Local):                                                                                                                  │
│Imported At (Local):                                                                                                               │
│Excess:                                                                                                                            │
│Confirmations:                                                                                                                     │
│Mined Height:                                                                                                                      │
│Maturity:                                                                                                                          │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
 Base Node Status  -  Chain Tip: #12365  Synced.  Latency 562 ms                  Connected Base Node ID: 99999903f5951fa1ca9505c3c2
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 Network: stagenet         Version: 0.49.0-pre.5     LeftArrow: Previous Tab  Tab/RightArrow: Next Tab              F10/Ctrl-Q: Quit

@CjS77
fix: resize transaction tab windows
00828a1 
PR #4942 added a row to the tx detail view, but did not increase the
size of the box. As a result, the maturity is cut off.

This PR makes the detail box one row wider, and adjusts the minimum size
of the tx box to be 8 (this is the absolute minimum -- accounting for
headers and one each of pending and completed txs).

Fixes #5289
@CjS77
Merge branch 'development' into 5289_tx_detail_size
1689284
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Apr 5, 2023
@CjS77 CjS77 added the A-wallet Area - related to the wallet label Apr 5, 2023
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Apr 5, 2023
@stringhandler stringhandler added the P-merge Process - Queued for merging label Apr 5, 2023
@stringhandler
Copy link
Collaborator

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-acks_required Process - Requires more ACKs or utACKs label Apr 5, 2023
@ghpbot-tari-project ghpbot-tari-project merged commit bd95a85 into development Apr 5, 2023
@CjS77 CjS77 deleted the 5289_tx_detail_size branch April 5, 2023 11:38
@SWvheerden SWvheerden mentioned this pull request Apr 5, 2023
Merged
SWvheerden added a commit that referenced this pull request Apr 5, 2023
@SWvheerden
chore(version): v0.49.0-pre.6 (#5292)
b6a93ee 
##
[0.49.0-pre.6](v0.49.0-pre.5...v0.49.0-pre.6)
(2023-04-05)


### ⚠ BREAKING CHANGES

* move key manager service to key_manager (5284)
* add igor faucet (5281)
* reset dates for networks (5283)

### Features

* add igor faucet
([5281](#5281))
([bfc92fd](bfc92fd))
* added auxiliary callback to push base node state changes
[5109](#5109)
([#5257](#5257))
([b7f7d31](b7f7d31))
* move key manager service to key_manager
([5284](#5284))
([d50ed02](d50ed02))
* reset dates for networks
([5283](#5283))
([d6342a4](d6342a4))


### Bug Fixes

* resize transaction tab windows
([5290](#5290))
([bd95a85](bd95a85)),
closes [#4942](#4942)
[#5289](#5289)
[#12365](https://github.com/tari-project/tari/issues/12365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
A-wallet Area - related to the wallet P-merge Process - Queued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timelocked outputs should be marked
3 participants
@CjS77 @stringhandler @ghpbot-tari-project