Add MMR rewinding #327
Merged
Add MMR rewinding #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created rewind and forward for MMR wip
CjS77
approved these changes
May 29, 2019
| @@ -49,6 +52,12 @@ pub(crate) struct MerkleCheckPoint { | |||
| pub objects_to_del: Vec<ObjectHash>, | |||
| mmr_to_add: Vec<MerkleNode>, | |||
| } | |||
|
|
|||
| pub(crate) struct CpCleanup { | |||
There was a problem hiding this comment.
Suggested change
| pub(crate) struct CpCleanup { | |
| pub(crate) struct CheckpointCleanup { |
Writing MMR out would be a screenful, Checkpoint is fine
| @@ -190,16 +282,45 @@ impl MerkleChangeTracker { | |||
| if !self.enabled { | |||
| return Ok(()); | |||
| } | |||
| hashmap.drain(); | |||
There was a problem hiding this comment.
I don't think this does anything. You still need to call collect() or take() on this struct
|
You probably want 'clear' then
…On Tue, Jun 4, 2019, 10:52 Mike the Tike ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In infrastructure/merklemountainrange/src/merkle_change_tracker.rs
<#327 (comment)>:
> @@ -190,16 +282,45 @@ impl MerkleChangeTracker {
if !self.enabled {
return Ok(());
}
+ hashmap.drain();
I don't think this does anything. You still need to call collect() or
take() on this struct
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#327?email_source=notifications&email_token=ABZZALZFFOIM6QPQC6H73KTPYYUNRA5CNFSM4HQK74EKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2PSSSQ#pullrequestreview-245311818>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZZAL7HUFEHAJYYHC3IGBTPYYUNRANCNFSM4HQK74EA>
.
|
|
Nvm, see it does the same as clear, just creates a new iterator at the same time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to rewind and forward the MMR without changing it permanently
Description
Motivation and Context
Fixes #288
How Has This Been Tested?
Added additional unit tests
Types of changes
Checklist:
developmentbranchcargo-fmt --allbefore pushing