feat: optimize transaction validation for wallet #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
force-pushed
the
ho_transaction_validation_batch_query
branch
from
4776570
to
7d99e12
Compare
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_transaction_validation_batch_query
branch
from
7d99e12
to
3e48f97
Compare
hansieodendaal
changed the title
Optimized the transaction validation memory footprint by restricting all queries to the database to only return the information that is needed. This holds two considerable advantages for databases with many or large transactions: - The memory foorprint is reduced. - Overall performance is increased.
hansieodendaal
force-pushed
the
ho_transaction_validation_batch_query
branch
from
3e48f97
to
3bf6001
Compare
philipr-za
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimized the transaction validation memory footprint by restricting all queries to the database to only return the information that is needed. This holds two considerable advantages for databases with many or large transactions:
Motivation and Context
See above.
How Has This Been Tested?
Unit tests
Cucumber tests
System-level tests with a large wallet