Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update committee from the committee definions TXs #3911

Merged
merged 3 commits into from
Apr 4, 2022
Merged

feat: update committee from the committee definions TXs #3911

merged 3 commits into from
Apr 4, 2022

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Mar 11, 2022

Description

Update the validation node based on the committee definitions.
Fixes the bug that I was not able to create asset.

How Has This Been Tested?

Manually (but only adding, since we don't have committee change option). But should work fine.

@stringhandler stringhandler added the P-clippy_failed Process - Clippy has failed label Mar 15, 2022
@Cifko Cifko force-pushed the feat--update-committee-from-the-definition-utxos branch from 2970e15 to 47dd4f9 Compare March 16, 2022 11:10
@Cifko Cifko removed the P-clippy_failed Process - Clippy has failed label Mar 16, 2022
sdbondi
sdbondi reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some comments

applications/tari_validator_node/src/dan_node.rs Outdated Show resolved Hide resolved
dan_layer/core/src/workers/consensus_worker.rs Outdated Show resolved Hide resolved
applications/tari_validator_node/Cargo.toml Outdated Show resolved Hide resolved
applications/tari_validator_node/src/asset.rs Outdated Show resolved Hide resolved
applications/tari_validator_node/src/asset.rs Outdated Show resolved Hide resolved
applications/tari_validator_node/src/asset.rs Outdated Show resolved Hide resolved
@Cifko Cifko force-pushed the feat--update-committee-from-the-definition-utxos branch 2 times, most recently from 2c046b6 to 403f387 Compare March 21, 2022 15:17
@Cifko Cifko force-pushed the feat--update-committee-from-the-definition-utxos branch from 403f387 to eb57915 Compare March 31, 2022 03:59
@Cifko Cifko force-pushed the feat--update-committee-from-the-definition-utxos branch from eb57915 to a84ef17 Compare March 31, 2022 04:03
@stringhandler stringhandler merged commit 0b29c89 into tari-project:development Apr 4, 2022
@Cifko Cifko deleted the feat--update-committee-from-the-definition-utxos branch June 23, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi left review comments

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cifko @sdbondi @stringhandler