refactor(core): tari newtype wraps MicroTari #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-tari-newtype-cleanup
branch
7 times, most recently
from
c525414
to
31f5dbc
Compare
sdbondi
force-pushed
the
core-tari-newtype-cleanup
branch
from
31f5dbc
to
558dcd2
Compare
stringhandler
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This avoids a fair amount of complexity and footguns. I wanted to remove the decimal dependency but it come in handy for the parsing of decimal strings. The only API breaking change is that negatives are not supported (not currently used) but this would be fairly straight forward to add.
How Has This Been Tested?
New and updated unit tests, Manually checked the wallet