Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hash echd secret #4334

Closed
wants to merge 1 commit into from
Closed

fix: hash echd secret #4334

wants to merge 1 commit into from

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Jul 22, 2022

Description

Hash echd secret.

Motivation and Context

#4110

@AaronFeickert
Copy link
Collaborator

When #4138 is addressed, there will be two separate keys derived from the ECDH shared secret: one is for ChaCha20 message encryption, and the other is for ChaCha20-Poly1305 authenticated signature encryption. To keep the intent and types clear, it may be better to have generate_ecdh_secret return a non-key type, and write separate key derivation functions that produce the appropriate derived keys.

@AaronFeickert
Copy link
Collaborator

See #4336 for current related work!

@jorgeantonio21
Copy link
Contributor

Currently, #4138 has been merged to development.

@Cifko Cifko closed this Aug 8, 2022
@Cifko Cifko deleted the hash-echd branch August 8, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cifko @AaronFeickert @jorgeantonio21