fix: grpc inconsistent serialization of keys (see issue #4224) #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes: #4224. |
| @@ -95,7 +95,7 @@ message SoftwareUpdate { | |||
| message GetIdentityRequest { } | |||
|
|
|||
| message GetIdentityResponse { | |||
| bytes public_key = 1; | |||
| string public_key = 1; | |||
There was a problem hiding this comment.
bytes is actually correct here. see the fix below rather
| @@ -198,9 +198,9 @@ impl wallet_server::Wallet for WalletGrpcServer { | |||
| async fn identify(&self, _: Request<GetIdentityRequest>) -> Result<Response<GetIdentityResponse>, Status> { | |||
| let identity = self.wallet.comms.node_identity(); | |||
| Ok(Response::new(GetIdentityResponse { | |||
| public_key: identity.public_key().to_string().into_bytes(), | |||
| public_key: identity.public_key().to_string(), | |||
There was a problem hiding this comment.
Suggested change
| public_key: identity.public_key().to_string(), | |
| public_key: Vec::from(identity.public_key().as_bytes()) |
There was a problem hiding this comment.
Thanks ! Why not just identity.public_key().to_vec() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We address inconsistent serialization of keys across base node and wallet grpc servers. The first uses a little endian 32-byte representation of the keys, whereas the second a 64-byte hex representation. We opt to use a hex-representation for the public key on the wallet grpc side.
Motivation and Context
Fixes #4224.
How Has This Been Tested?
Manually.