feat: let sql in wal mode provide async db, not app level spawn blocking (transaction service) #4597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
force-pushed
the
ho_remove_spawn_blocking_tranaction_service
branch
5 times, most recently
from
393a526
to
0254bc0
Compare
Removed spawn blocking calls for db operations from the wallet in the transaction service. (This is the last PR in a couple of PRs required to implement this fully throughout the wallet code.)
hansieodendaal
force-pushed
the
ho_remove_spawn_blocking_tranaction_service
branch
from
0254bc0
to
a484b57
Compare
hansieodendaal
changed the title
hansieodendaal
changed the title
hansieodendaal
changed the title
hansieodendaal
changed the title
sdbondi
approved these changes
Sep 2, 2022
hansieodendaal
deleted the
ho_remove_spawn_blocking_tranaction_service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed spawn blocking calls for db operations from the wallet in the transaction service.
(This is the last PR in a couple of PRs required to implement this fully throughout the wallet code.)
Motivation and Context
As per #3982 and #4555
How Has This Been Tested?
Unit tests
Cucumber tests