Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core)!: adds utxo and block info to get_template_registrations request #4789

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Oct 10, 2022

Description

  • adds UTXO and block info to get_template_registrations request
  • adds end_height to get_template_registrations request
  • Changes validator node registration key to <block_height, output_hash>
  • uses CompositeKey for all composite keys
  • Removed some unused (previous contract code) response types

Motivation and Context

DAN template scanner requires block hash info to determine last scanned height.
Indexing template validations by block height enable more efficient retrievals

NOTE: blockchain db will need to be resynced

How Has This Been Tested?

Manually - DAN block scanner

@sdbondi sdbondi force-pushed the base-node-return-utxo-info-for-template-reg branch from 2b143c6 to 0cbfac4 Compare October 10, 2022 06:49
@sdbondi sdbondi marked this pull request as draft October 10, 2022 10:28
@sdbondi sdbondi force-pushed the base-node-return-utxo-info-for-template-reg branch 2 times, most recently from 046adb1 to 5fe8acc Compare October 11, 2022 09:25
@sdbondi sdbondi marked this pull request as ready for review October 11, 2022 13:48
@sdbondi sdbondi force-pushed the base-node-return-utxo-info-for-template-reg branch from 5fe8acc to 0877915 Compare October 11, 2022 13:49
@sdbondi sdbondi force-pushed the base-node-return-utxo-info-for-template-reg branch from 0877915 to cff33f7 Compare October 11, 2022 15:18
@sdbondi sdbondi changed the title fix(core)!: adds utxo and block info to get_remplate_registrations request fix(core)!: adds utxo and block info to get_remplate_tegistrations request Oct 11, 2022
@sdbondi sdbondi changed the title fix(core)!: adds utxo and block info to get_remplate_tegistrations request fix(core)!: adds utxo and block info to get_template_tegistrations request Oct 11, 2022
@sdbondi sdbondi changed the title fix(core)!: adds utxo and block info to get_template_tegistrations request fix(core)!: adds utxo and block info to get_template_registrations request Oct 11, 2022
@stringhandler stringhandler merged commit 9e81c7b into tari-project:feature-dan Oct 11, 2022
@sdbondi sdbondi deleted the base-node-return-utxo-info-for-template-reg branch October 11, 2022 16:00
sdbondi added a commit to sdbondi/tari that referenced this pull request Nov 14, 2022
* feature-dan: (21 commits)
  fix(core)!: remove unused get_committees call from base node (tari-project#4880)
  fix: correct value for validator_node_timeout consensus constant in localnet (tari-project#4879)
  feat: add block height to input request to get network consensus constants (tari-project#4856)
  fix: remove unused config for validator node (tari-project#4849)
  feat: add missing fields to grpc consensus constants interface (tari-project#4845)
  chore: merge development into feature-dan (tari-project#4815)
  refactor: split tari_base_node and tari_console_wallet into a lib component (tari-project#4818)
  fix(core)!: adds utxo and block info to get_template_registrations request (tari-project#4789)
  fix: computation of vn mmr (tari-project#4772)
  fix(wallet/grpc): add transaction id and template_address to template_reg response (tari-project#4788)
  fix: fix get shard key (tari-project#4744)
  feat(core): store and fetch templates from lmdb (tari-project#4726)
  fix: fix validator node registration logic (tari-project#4718)
  feat(base_node_grpc_client): add getActiveValidatorNodes method (tari-project#4719)
  fix after merge
  fix(core): bring validator node MR inline with other merkle root code (tari-project#4692)
  feat(core): add validator registration sidechain feature (tari-project#4690)
  fix merge issues
  feat: add grpc to get shard key for public key (tari-project#4654)
  feat: add validator node registration (tari-project#4507)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants