feat: improve message encryption #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
changed the title
ghpbot-tari-project
added
P-acks_required
AaronFeickert
force-pushed
the
masked-message-sig
branch
4 times, most recently
from
2a5ec90
to
a63a949
Compare
|
Just marking this with DNM for now until the tari crypto version has been published to crates.io |
AaronFeickert
force-pushed
the
masked-message-sig
branch
3 times, most recently
from
731451e
to
1ab2ba6
Compare
AaronFeickert
force-pushed
the
masked-message-sig
branch
3 times, most recently
from
6431962
to
b92b61c
Compare
@stringhandler: Should be fine to remove this label now. |
AaronFeickert
force-pushed
the
masked-message-sig
branch
2 times, most recently
from
7b9648b
to
ba5a9b0
Compare
SWvheerden
previously approved these changes
Apr 17, 2023
ghpbot-tari-project
removed
the
P-reviews_required
|
utAck |
AaronFeickert
force-pushed
the
masked-message-sig
branch
from
ba5a9b0
to
15974b8
Compare
SWvheerden
previously approved these changes
Apr 18, 2023
AaronFeickert
force-pushed
the
masked-message-sig
branch
from
15974b8
to
7a1c0d8
Compare
SWvheerden
approved these changes
Apr 18, 2023
SWvheerden
added a commit
that referenced
this pull request
May 8, 2023
## [0.50.0-pre.1](v0.50.0-pre.0...v0.50.0-pre.1) (2023-05-08) ### Features * add miner timeout config option ([5331](#5331)) ([aea14f6](aea14f6)) * chat ffi ([5349](#5349)) ([f7cece2](f7cece2)) * chat scaffold ([5244](#5244)) ([5b09f8e](5b09f8e)) * improve message encryption ([5288](#5288)) ([7a80716](7a80716)) * **p2p:** allow listener bind to differ from the tor forward address ([5357](#5357)) ([857fb55](857fb55)) ### Bug Fixes * add SECURITY.md Vulnerability Disclosure Policy ([5351](#5351)) ([72daaf5](72daaf5)) * added missing log4rs features ([5356](#5356)) ([b9031bb](b9031bb)) * allow public addresses from command line ([5303](#5303)) ([349ac89](349ac89)) * clippy issues with config ([5334](#5334)) ([026f0d5](026f0d5)) * default network selection ([5333](#5333)) ([cf4b2c8](cf4b2c8)) * make the first output optional in the wallet ([5352](#5352)) ([bf16140](bf16140)) * remove wallet panic ([5338](#5338)) ([536d16d](536d16d)) * wallet .h file for lib wallets ([5330](#5330)) ([22a3a17](22a3a17))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves message encryption using key-blinding signatures. Updates
tari-cryptoto the latest version for proper compatibility.Closes issue 5255.
Motivation and Context
Currently, message encryption uses an encrypted signature. A recent formalization of key-blinding signatures offers an interesting new approach that allows any network node to verify an unencrypted signature on a masked key. This PR updates message encryption to use such a design.
How Has This Been Tested?
Existing, modified, and new tests pass.
What process can a PR reviewer use to test or verify this change?
Examine and run tests. Assert that message encryption follows these flowcharts.
Breaking Changes
None. While existing messages will not verify, this should not affect new messages that use the updated design.