Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make the first output optional in the wallet #5352

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix: make the first output optional in the wallet #5352

merged 1 commit into from
Apr 25, 2023

Conversation

therustmonk
Copy link
Contributor

Description

The PR prevents panic in getting the first output of the UtxoScannerTask.

Motivation and Context

The tari_console_wallet app fails when a node is syncing:

 Base Node Status  - Chain Tip: #3498  Syncing...  Latency 630 ms
thread 'tokio-runtime-worker' panicked at 'index out of bounds: the len is 0 but the index is 0',
/home/denis/tari/base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs:484:37────────
 Network: esmeralda        Version: 0.50.0-pre.0    LeftArrow: Previous Tab  Tab/RightArrow: Next Tab
F10/Ctrl-note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)

P.S. I wonder if the None value of the first_output variable breaks something, and we must panic there.

How Has This Been Tested?

Manually, by starting the tari_console_wallet with the changes.

@ghpbot-tari-project ghpbot-tari-project added the P-acks_required Process - Requires more ACKs or utACKs label Apr 25, 2023
@stringhandler stringhandler merged commit bf16140 into tari-project:development Apr 25, 2023
@SWvheerden SWvheerden mentioned this pull request May 8, 2023
Merged
SWvheerden added a commit that referenced this pull request May 8, 2023
@SWvheerden
chore: new version for development (#5371)
41b7d84 
##
[0.50.0-pre.1](v0.50.0-pre.0...v0.50.0-pre.1)
(2023-05-08)


### Features

* add miner timeout config option
([5331](#5331))
([aea14f6](aea14f6))
* chat ffi ([5349](#5349))
([f7cece2](f7cece2))
* chat scaffold
([5244](#5244))
([5b09f8e](5b09f8e))
* improve message encryption
([5288](#5288))
([7a80716](7a80716))
* **p2p:** allow listener bind to differ from the tor forward address
([5357](#5357))
([857fb55](857fb55))


### Bug Fixes

* add SECURITY.md Vulnerability Disclosure Policy
([5351](#5351))
([72daaf5](72daaf5))
* added missing log4rs features
([5356](#5356))
([b9031bb](b9031bb))
* allow public addresses from command line
([5303](#5303))
([349ac89](349ac89))
* clippy issues with config
([5334](#5334))
([026f0d5](026f0d5))
* default network selection
([5333](#5333))
([cf4b2c8](cf4b2c8))
* make the first output optional in the wallet
([5352](#5352))
([bf16140](bf16140))
* remove wallet panic
([5338](#5338))
([536d16d](536d16d))
* wallet .h file for lib wallets
([5330](#5330))
([22a3a17](22a3a17))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@therustmonk @stringhandler @ghpbot-tari-project