fix: default network selection #5333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove common as dependency form tari-features Features is now a frequently used build dep in most of our crates. Common actually also needs to be feature aware during build time. This means tari-features should have little to no dependencies, especially none from our own crates. This caused a bug with the default network selection, as tari-feature wasn't successfully included in tari-common, causing the default network selection to downgrade its selection to TestNet regardless of the build.
brianp
force-pushed
the
fix-default-networks-development
branch
from
f697741
to
0b25c89
Compare
ghpbot-tari-project
added
P-acks_required
4 tasks
SWvheerden
approved these changes
Apr 17, 2023
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
pushed a commit
that referenced
this pull request
Apr 18, 2023
Description --- Features is now a frequently used build dep in most our crates. Common actually also needs to be feature aware during build time. This means tari-features should have little to no dependencies, and especially none from our own crates. Motivation and Context --- Related to #5326 Development fix: #5333 How Has This Been Tested? --- Manually What process can a PR reviewer use to test or verify this change? --- Run cargo build with the desired network type (nextnet): `TARI_NETWORK=nextnet cargo build --bin tari_base_node` Run the bin directly without using cargo. It's important not to use cargo during the testing as the bin will likely rebuild when using `run` and change the previous `TARI_NETWORK` compilation settings: `./target/tari_base_node` See that the default network is NextNet. <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
SWvheerden
added a commit
that referenced
this pull request
May 8, 2023
## [0.50.0-pre.1](v0.50.0-pre.0...v0.50.0-pre.1) (2023-05-08) ### Features * add miner timeout config option ([5331](#5331)) ([aea14f6](aea14f6)) * chat ffi ([5349](#5349)) ([f7cece2](f7cece2)) * chat scaffold ([5244](#5244)) ([5b09f8e](5b09f8e)) * improve message encryption ([5288](#5288)) ([7a80716](7a80716)) * **p2p:** allow listener bind to differ from the tor forward address ([5357](#5357)) ([857fb55](857fb55)) ### Bug Fixes * add SECURITY.md Vulnerability Disclosure Policy ([5351](#5351)) ([72daaf5](72daaf5)) * added missing log4rs features ([5356](#5356)) ([b9031bb](b9031bb)) * allow public addresses from command line ([5303](#5303)) ([349ac89](349ac89)) * clippy issues with config ([5334](#5334)) ([026f0d5](026f0d5)) * default network selection ([5333](#5333)) ([cf4b2c8](cf4b2c8)) * make the first output optional in the wallet ([5352](#5352)) ([bf16140](bf16140)) * remove wallet panic ([5338](#5338)) ([536d16d](536d16d)) * wallet .h file for lib wallets ([5330](#5330)) ([22a3a17](22a3a17))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Features is now a frequently used build dep in most our crates. Common actually also needs to be feature aware during build time. This means tari-features should have little to no dependencies, and especially none from our own crates.
Motivation and Context
Related to issue #5326
Related to nextnet hotfix #5327
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Run cargo build with the desired network type (nextnet):
TARI_NETWORK=nextnet cargo build --bin tari_base_nodeRun the bin directly without using cargo. It's important not to use cargo during the testing as the bin will likely rebuild when using
runand change the previousTARI_NETWORKcompilation settings:./target/tari_base_nodeSee that the default network is NextNet.
Breaking Changes