fix(core/weighting): remove optional and define correct rounding for usize::MAX #5490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-weighting-redefine-features_and_script_bytes_per_gram
branch
2 times, most recently
from
80b0187
to
5433a12
Compare
ghpbot-tari-project
added
P-acks_required
sdbondi
force-pushed
the
core-weighting-redefine-features_and_script_bytes_per_gram
branch
from
5433a12
to
d5d8a33
Compare
SWvheerden
approved these changes
Jun 23, 2023
ghpbot-tari-project
removed
the
P-reviews_required
sdbondi
deleted the
core-weighting-redefine-features_and_script_bytes_per_gram
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make features_and_scripts_byte_per_gram mandatory and update the weighting code
Motivation and Context
The optional features_and_scripts_bytes_per_gram was previously optional to keep compatibility with a previous block/tx weighting calculation which did not account for metadata bytes (i.e. features_and_scripts_bytes_per_gram is None). This is no longer needed.
How Has This Been Tested?
Existing tests, updated a unit test
What process can a PR reviewer use to test or verify this change?
Mine blocks containing transactions
Breaking Changes