chore: hotfix stagenet 0.49.2 #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the ffi call to create and start the wallet will block until connections have been made. Instead return the Wallet asap, and throw the previously blocking call into an async non blocking call and let it complete on its own time.
This includes the wallet ffi updates for non blocking initialization.
ghpbot-tari-project
added
the
P-acks_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes the fix for a non blocking wallet-ffi initialization required by the mobile apps, which are now running on stagenet.
Motivation and Context
Without this change the wallets will block while waiting for a tor connection.
How Has This Been Tested?
The wallet team... may have tried it... maybe.
Breaking Changes