fix: make tor startup async #6058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
| let transport = hidden_service_ctl.initialize_transport().await?; | ||
| let instant = Instant::now(); | ||
| let transport = HiddenServiceTransport::new(hidden_service_ctl); | ||
| error!(target: LOG_TARGET, "TOR transport initialized in {:.0?}", instant.elapsed()); |
There was a problem hiding this comment.
Why would this be an error log and not an info or debug log?
|
replaced by : #6092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move tor connection to be lazy
Motivation and Context
Previously, the wallet_create method would wait for tor to connect before it would return. This makes for a very slow experience, especially if you just want to read values from the database.
How Has This Been Tested?
This is still in progress, but I'm testing with some adhoc timing methods in the wallet_create method.
What process can a PR reviewer use to test or verify this change?
Kind of difficult, it can be seen mostly in the ios and android apps
Breaking Changes