chore: make MAC equality check more idiomatic #6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
AaronFeickert
force-pushed
the
subtle-mac-compare
branch
from
fd40ccc
to
004d526
Compare
Test Results (CI)1 270 tests 1 270 ✅ 11m 38s ⏱️ Results for commit 004d526. |
sdbondi
approved these changes
Feb 6, 2024
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
approved these changes
Feb 6, 2024
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Feb 15, 2024
* development: (120 commits) chore: use log4rs 1.3 (tari-project#6148) fix: balanced binary merkle tree merged proof (tari-project#6144) chore(deps): bump libgit2-sys from 0.16.1+1.7.1 to 0.16.2+1.7.2 (tari-project#6145) feat: allow ffi to see lock height (tari-project#6140) chore(ci): add metrics targeted build, remove miner artifacts, misc clean ups (tari-project#6141) chore: suppress error (tari-project#6137) chore: fix versions to correct version (tari-project#6135) chore: add stringhandler gpg (tari-project#6134) chore: add pgp public key (tari-project#6139) feat: turn off node metrics by default (tari-project#6073) feat: add import tx method (tari-project#6132) chore: update pgp public key (tari-project#6129) chore: new testnet release (tari-project#6127) chore: update pgp key (tari-project#6128) fix(libtor): prevent metrics port conflict (tari-project#6125) fix(comms): correctly initialize hidden service (tari-project#6124) chore: make MAC equality check more idiomatic (tari-project#6123) chore: new release (tari-project#6120) fix: restart tx fix (tari-project#6119) chore: suppress warn log (tari-project#6118) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the handling of cipher seed message authentication codes (MACs) to be more idiomatic.
Motivation and Context
A cipher seed has an associated MAC that is checked during decryption in constant time. Rather than using
Choice::unwrap_u8as is currently done, this PR uses the more idiomaticInto<bool>onChoiceto be more resistant to mistakes or misuse. It also changes the logic slightly to avoid "failing open" by no longer returning anOkat the end of the function by default, which helps to simplify the code and make the intent more clear.How Has This Been Tested?
Existing tests pass.
What process can a PR reviewer use to test or verify this change?
Check that the updated logic matches the existing logic.