Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide unmined coinbase #6159

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

This reintroduced code to hide unmined coinbase transactions.

Motivation and Context

Will show and hide depending on the user preference all coinbases that are reorged out and not in the main chain anymore.

Copy link

github-actions bot commented Feb 20, 2024

Test Results (CI)

    3 files    117 suites   39m 13s ⏱️
1 260 tests 1 260 ✅ 0 💤 0 ❌
3 772 runs  3 772 ✅ 0 💤 0 ❌

Results for commit bc8edce.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Feb 20, 2024
Copy link

github-actions bot commented Feb 20, 2024

Test Results (Integration tests)

29 tests   29 ✅  13m 21s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit bc8edce.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Mar 1, 2024
@SWvheerden SWvheerden merged commit 2ccde17 into tari-project:development Mar 1, 2024
15 of 16 checks passed
sdbondi added a commit to sdbondi/tari that referenced this pull request Mar 5, 2024
* development:
  feat: make the make_it_rain submission rate a float (tari-project#6180)
  feat: wallet ffi use dns (tari-project#6152)
  chore: add localnet gen block (tari-project#6176)
  fix: hide unmined coinbase (tari-project#6159)
  chore: removes panics from wallet burn task (tari-project#6163)
  test: fix cucumber network environment (tari-project#6175)
  feat: lazily evaluate for new random_x template (tari-project#6170)
@SWvheerden SWvheerden deleted the sw_fix_hide_unmined_coinbase branch March 5, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants