feat: lazily evaluate for new random_x template #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)1 260 tests 1 259 ✅ 16m 41s ⏱️ For more details on these failures, see this check. Results for commit 555aacb. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)0 tests 0 ✅ 0s ⏱️ For more details on these parsing errors, see this check. Results for commit 555aacb. ♻️ This comment has been updated with latest results. |
hansieodendaal
force-pushed
the
ho_lazy_evaluate_randomx_template
branch
6 times, most recently
from
9206eab
to
00b8554
Compare
- Changed the merge mining proxy to lazily evaluate RandomX block template changes. Greedily evaluating this is very expensive, especially during busy network times with a highly volatile mempool. - Fixed a bug where the command-line network argument 'igor' specified for the merge mining proxy was not recognized in the network-aware 'DomainSeparatedConsensusHasher'
hansieodendaal
force-pushed
the
ho_lazy_evaluate_randomx_template
branch
from
00b8554
to
c6c5079
Compare
SWvheerden
reviewed
Feb 29, 2024
applications/minotari_merge_mining_proxy/src/block_template_data.rs
Outdated
Show resolved
Hide resolved
SWvheerden
approved these changes
Mar 1, 2024
ghpbot-tari-project
removed
the
P-reviews_required
4 tasks
SWvheerden
pushed a commit
that referenced
this pull request
Mar 1, 2024
Description --- Fixed cucumber network environment Motivation and Context --- The cucumber environment uses a single runtime environment and the network should be set prior to use. Fixes cucumber test failures introduced by #6170. How Has This Been Tested? --- Applicable cucumber pass What process can a PR reviewer use to test or verify this change? --- Verify that `Scenario: Clear out mempool` passes **Note:** #6172 also introduced other cucumber errors <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Mar 5, 2024
* development: feat: make the make_it_rain submission rate a float (tari-project#6180) feat: wallet ffi use dns (tari-project#6152) chore: add localnet gen block (tari-project#6176) fix: hide unmined coinbase (tari-project#6159) chore: removes panics from wallet burn task (tari-project#6163) test: fix cucumber network environment (tari-project#6175) feat: lazily evaluate for new random_x template (tari-project#6170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
igorspecified for the merge mining proxy was not recognized in the network-aware 'DomainSeparatedConsensusHasher'config.tomlto be in line with coreMotivation and Context
nextnetthat lasted multiple hours, RandomX mining virtually ground to a halt during the stress test, whereas SHAR3 mining was able to continue.How Has This Been Tested?
igor)igor)igor)What process can a PR reviewer use to test or verify this change?
Code walk-through, system-level testing
Breaking Changes