test: fix cucumber network environment #6175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
previously approved these changes
Mar 1, 2024
ghpbot-tari-project
added
the
P-acks_required
hansieodendaal
force-pushed
the
ho_fix_cucumber
branch
from
6b7179e
to
f18b16e
Compare
Test Results (CI) 3 files 117 suites 37m 0s ⏱️ Results for commit f18b16e. |
ghpbot-tari-project
added
the
P-reviews_required
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Mar 5, 2024
* development: feat: make the make_it_rain submission rate a float (tari-project#6180) feat: wallet ffi use dns (tari-project#6152) chore: add localnet gen block (tari-project#6176) fix: hide unmined coinbase (tari-project#6159) chore: removes panics from wallet burn task (tari-project#6163) test: fix cucumber network environment (tari-project#6175) feat: lazily evaluate for new random_x template (tari-project#6170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed cucumber network environment
Motivation and Context
The cucumber environment uses a single runtime environment and the network should be set prior to use.
Fixes cucumber test failures introduced by #6170.
How Has This Been Tested?
Applicable cucumber pass
What process can a PR reviewer use to test or verify this change?
Verify that
Scenario: Clear out mempoolpassesNote: #6172 also introduced other cucumber errors
Breaking Changes