Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes panics from wallet burn task #6163

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Removes panics from wallet burn task

@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Feb 21, 2024
Copy link

Test Results (CI)

1 260 tests   1 260 ✅  11m 14s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit 5cb6a37.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Feb 21, 2024
Copy link

Test Results (Integration tests)

29 tests  +29   29 ✅ +29   11m 58s ⏱️ + 11m 58s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 5cb6a37. ± Comparison against base commit f5860a8.

Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
utAck

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Mar 1, 2024
@SWvheerden SWvheerden merged commit a875934 into tari-project:development Mar 1, 2024
13 of 14 checks passed
sdbondi added a commit to sdbondi/tari that referenced this pull request Mar 5, 2024
* development:
  feat: make the make_it_rain submission rate a float (tari-project#6180)
  feat: wallet ffi use dns (tari-project#6152)
  chore: add localnet gen block (tari-project#6176)
  fix: hide unmined coinbase (tari-project#6159)
  chore: removes panics from wallet burn task (tari-project#6163)
  test: fix cucumber network environment (tari-project#6175)
  feat: lazily evaluate for new random_x template (tari-project#6170)
@SWvheerden SWvheerden deleted the sw_stop_burn_panics branch March 5, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants