fix!: change grpc deny to allow #6218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Test Results (CI) 3 files 120 suites 49m 46s ⏱️ Results for commit e16e374. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 32m 49s ⏱️ For more details on these failures, see this check. Results for commit e16e374. ♻️ This comment has been updated with latest results. |
Co-authored-by: Stan Bondi <sdbondi@users.noreply.github.com>
SWvheerden
force-pushed
the
sw_allow_list
branch
from
a9fda1f
to
8b85be1
Compare
common/config/presets/c_base_node_b_non_mining_allow_methods.toml
Outdated
Show resolved
Hide resolved
| @@ -119,18 +119,18 @@ pub fn prompt_default_config() -> [&'static str; 12] { | |||
| /// Returns the default configuration file template in parts from the embedded presets. If use_mining_config is true, | |||
| /// the base node configuration that enables mining is returned, otherwise the non-mining configuration is returned. | |||
| pub fn get_default_config(use_mining_config: bool) -> [&'static str; 12] { | |||
| let base_node_deny_methods = if use_mining_config { | |||
| include_str!("../../config/presets/c_base_node_b_mining_deny_methods.toml") | |||
| let base_node_allow_methods = if use_mining_config { | |||
There was a problem hiding this comment.
What about these methods second_layer_grpc_enabled ? I assume it should be set from initial startup.
A node could also double as mining node and second layer comms node.
Co-authored-by: Hansie Odendaal <39146854+hansieodendaal@users.noreply.github.com>
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the antipattern of a deny list and puts in an allow list
Motivation and Context
A deny list is an antipattern because new methods are not automatically added to the list
Replaces: #6177