feat!: remove user agent config option #6320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 37m 53s ⏱️ Results for commit 085dc5b. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 23m 38s ⏱️ For more details on these failures, see this check. Results for commit 085dc5b. |
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the user-controlled user_agent field from the config and makes this a coded option only.
Motivation and Context
This field is used by the application to report its name to the network. By default for the desktop and mobile apps this option is filled in by the application and reports the name and version of the application. This is very helpful for the network to decern whom they are connection to.
Leaving this option to user change, makes it very easy to remove this option on an individual bases. Currently Launchpad already does this and only reports like follows:
Although this does not stop a user from changing this field, it lifts the barrier to do this by requiring code changes.
Breaking Changes
Removes config option.