Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${ZGEN_LOADED} and ${ZGEN_COMPLETIONS} aren't wiped after loading ${ZGEN_INIT} #7

Closed
unixorn opened this issue Dec 23, 2014 · 0 comments · Fixed by #8
Closed

${ZGEN_LOADED} and ${ZGEN_COMPLETIONS} aren't wiped after loading ${ZGEN_INIT} #7

unixorn opened this issue Dec 23, 2014 · 0 comments · Fixed by #8

Comments

@unixorn
Copy link
Contributor

unixorn commented Dec 23, 2014

I noticed while I was trimming my plugin list today that ones I thought I'd deleted were still present in ${ZGEN_INIT} after I ran zgen save. I realized that ${ZGEN_LOADED} and ${ZGEN_COMPLETIONS} weren't emptied.

There either needs to be a convenient way to reset ${ZGEN_LOADED} and ${ZGEN_COMPLETIONS} when you're creating a new save file, or we should just blank them at the end of ${ZGEN_INIT}. I'm in favor of just automatically blanking them.

unixorn added a commit to unixorn/zgen that referenced this issue Dec 23, 2014
We weren't claring `${ZGEN_COMPLETIONS}` and `${ZGEN_LOADED}` after
loading `${ZGEN_INIT}`. This made it impossible to delete a plugin -
every time I'd do `zgen save`, it would include them since they were
already in the arrays.

Closes tarjoilija#7
unixorn added a commit to unixorn/zgen that referenced this issue Dec 23, 2014
Use source in `${ZGEN_INIT}` instead of -zgen-source. Fixes tarjoilija#7, with the
welcome side effect of being 11% faster.
jfoster pushed a commit to jforkster/zgen that referenced this issue Jan 17, 2019
Fix oh-my-zsh and prezto confilct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant