the git-hooks can not work on windows(mingw)

[snowyu]

[GIT-HOOKS ERROR] Cannot find module '....
node_modulesgit-hookslib/git-hooks'

the path delimiter of the generated hook files is error:

.git/hooks/post-commit:

#!/usr/bin/env node

try {
    require('..\..\node_modules\git-hooks\lib/git-hooks').run(__filename, process.argv[2], function (code) {
        process.exit(code);
    });
} catch (e) {
    console.error('[GIT-HOOKS ERROR] ' + e.message);
}

[tarmolov]

To be honest, I didn't test git-hooks on Windows but if you have any time to make pr, I'll really appreciate it ;)

See also #7 (comment)

[aliosv]

Current problems:

1. wrong path to git-hooks in template
2. checking file on the execution not works in windows
3. problems with spawn(windows not support shebangs)
   here fast fix Windows support #11

[tarmolov]

Could you tell me in details about each of problem please?

[aliosv]

1. https://github.com/tarmolov/git-hooks-js/blob/master/lib/hook-template.js#L4 -> wrong path(at least no backslash escaping) '....\lib/git-hooks'
2. https://github.com/tarmolov/git-hooks-js/blob/master/lib/git-hooks.js#L148 always falsy. Stats={mode:33206,gid:0,uid:0}. process.getid/uid = undefined(https://nodejs.org/api/process.html#process_process_getegid)
3. Windows choose executable program by file extension. You can associate file extensions with executable programs(script.bash -> execute by bash), but we use shebangs instead of extensions, which windows not support.

[tarmolov]

1. path.join should fix this problem.
2. It seems that for win32 should be always returned true https://github.com/kevva/executable/blob/master/index.js#L7-L9
3. spawn for windows is trickier than you think https://github.com/IndigoUnited/node-cross-spawn-async but handling shebang is probably enough for the majority cases. And again it's better to store all windows related stuff in a separate file. Just for the record, shebang-regex is just one line module and shebang-command is 7 lines long.

[aliosv]

1. path.join returns '....\lib\git-hooks', in hook-template you need to have '....\lib\git-hooks', so you also need to escape backslashes.
2. if you agree with shebangs, why ont to leave current check(if file not contain, then it is not executable for windows)?
3. i will get rid of dependencies, about separate file i wrote earlier: explain in details, i don't see what to move(spawnHook function?)

[cinderblock]

Why not just use POSIX-compliant paths when on win32? Get rid of all those pesky backslashes asap.

I'm creating a PR that does this. It also fixes an endless loop that can occur on win32 systems.

Why not use cross-spawn-async to fix all of our spawn issues?

[cinderblock]

Actually, why is the path to git-hooks even used in the hooks? Pushing another commit shortly.

[tarmolov]

cross-spawn-async isn't used because of npm@2 bug npm/npm#8850

[7oque]

The static path being added here also prevents hooks from running successfully when using a git gui (as the gui does not run from the same place). Would it be possible for it to work out the path of the project with something like require('path').resolve(__dirname); ?

[tarmolov]

Sorry. I didn't get you.
Do you mean that https://github.com/tarmolov/git-hooks-js/blob/master/lib/hook-template.js#L11 doesn't work?

[7oque]

I had not seen that update, looks exactly like the upgrade required (I have no idea what is available to git hooks). Thanks so much!