Skip to content
This repository was archived by the owner on Jan 5, 2019. It is now read-only.

Bug 1462811 - allow task template to set taskGroupId #100

Merged
merged 2 commits into from
May 22, 2018
Merged

Bug 1462811 - allow task template to set taskGroupId #100

merged 2 commits into from
May 22, 2018

Conversation

djmitche
Copy link
Contributor

No description provided.

@djmitche djmitche self-assigned this May 18, 2018
@djmitche djmitche requested a review from jonasfj May 18, 2018 22:52
@djmitche
Copy link
Contributor Author 

make: Entering directory '/repo/node_modules/buffertools/build'
gyp info spawn make
  CXX(target) Release/obj.target/buffertools/buffertools.o
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
In file included from /root/.node-gyp/8.11.2/include/node/node.h:63:0,
                 from ../buffertools.cc:17:
/root/.node-gyp/8.11.2/include/node/v8.h:15:0: error: unterminated #ifndef
 #ifndef INCLUDE_V8_H_

I really love the JS ecosystem...

@djmitche djmitche closed this May 18, 2018
@djmitche djmitche reopened this May 18, 2018
@escapewindow escapewindow mentioned this pull request May 22, 2018
Merged
@djmitche djmitche merged commit fecc0cf into taskcluster:master May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jonasfj jonasfj jonasfj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@djmitche djmitche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djmitche @jonasfj