This repository was archived by the owner on Jan 5, 2019. It is now read-only.
Bug 1490456 - bug fixes in recycling timing #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case where a connection has already been retired when we start to connect to it; also use `newConn.failed()` when connecting fails, as that will only recycle if the connection hasn't already been retired. This also fixes the test: the comment said 10ms but the code said 20ms; 10ms was the correct answer.
- always return a Date instance from credentials functions - simplify the recycling timing into one timer, which it is careful to clear before resetting. Since it's difficult to test timers, simpler is better. It's handled in a single function, separate from credential fetching.
Biboswan
reviewed
Sep 12, 2018
|
v2.0.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is pretty straightforward; the second is a more substantial refactor of timer handling. I recognize that it changes the behavior a little bit, in that it completely ignores recycleInterval when using a credentials function that returns recycleAt, but I think that's OK -- the idea of recycleInterval is just to make sure we don't stay connected forever, and recycleAt accomplishes that goal too.