Added hintId to all pending azure queue messages #124

Merged
merged 3 commits into from Oct 17, 2016

Projects

None yet

3 participants

@jonasfj
Member
jonasfj commented Oct 14, 2016

Once this is deployed we can modify the claimWork logic to ensure that we record the hintId for each claim...
Notably we can use this ensure that two different azure messages doesn't lead to the same task being claimed twice by the same worker (when there is a duplication of azure messages)...

Note: this could break workers if they won't ignore extra properties...
@petemoore ^ do you know if additional properties will break generic-worker, I doubt it.. but it would be hard to back out...

jonasfj added some commits Oct 14, 2016
@jonasfj jonasfj Added hintId to all pending azure queue messages 8c0140f
@jonasfj jonasfj change some: var -> let 3fc5335
@jonasfj jonasfj referenced this pull request Oct 14, 2016
Merged

change some: var -> let #125

@jonasfj
Member
jonasfj commented Oct 14, 2016

@petemoore, gave an r+ for this on IRC...

@jonasfj
Member
jonasfj commented Oct 14, 2016

as per IRC discussion with pete this should be perfectly safe to deploy...

@jonasfj jonasfj referenced this pull request Oct 14, 2016
Merged

Use hint #126

@jonasfj jonasfj merged commit 5d63480 into master Oct 17, 2016

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@jonasfj jonasfj deleted the add-hint-id branch Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment