fix: ack to the right stream in case of dynamic queue name #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @chandr-andr, I missed that on previous PRs |
|
@FlorianLB No problem. But mypy is failed now, could you please fix it? |
FlorianLB
force-pushed
the
fix-dynamic-ack
branch
from
8347d00 to
cb635b6
Compare
|
@chandr-andr fixed |
|
@FlorianLB Thanks! |
|
Thx a lot 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #94 and #100 , the ack for
StreamBrokeris wrong as it does not take into account the dynamic queue name and always ack on the "main" queue.This PR fix that issue.