Skip to content

Add redis async backend #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 2, 2022
Merged

Add redis async backend #2

merged 8 commits into from
Aug 2, 2022

Conversation

chandr-andr
Copy link
Member

@chandr-andr chandr-andr commented Jul 30, 2022

No description provided.

@chandr-andr
Copy link
Member Author

@s3rius @wbwswt Please see this pull request

Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't follow PEP-420 and breaks structure. Please update the package.

@s3rius
Copy link
Member

s3rius commented Jul 31, 2022

Please change structure of your project. Because now it imports errors package in taskiq/result_backends.

Please move all your code in

taskiq-redis/taskiq/result_backends/redis/

taskiq-redis
├── __init__.py
└── taskiq
    └── result_backends
        └── redis
            ├── errors
            │   ├── __init__.py
            │   └── redis_errors.py
            ├── __init__.py
            ├── redis_backend.py
            └── redis_client.py

After that you can import RedisAsyncResultBackend like this:

from taskiq.result_backends.redis import RedisAsyncResultBackend

@chandr-andr chandr-andr requested a review from s3rius July 31, 2022 21:54
Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quality is good, but I think we must update taskiq to make it easier to write new result backends.

@s3rius s3rius linked an issue Aug 2, 2022 that may be closed by this pull request
Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more changes needed.

Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.

@chandr-andr chandr-andr merged commit 4dab5c5 into main Aug 2, 2022
@s3rius s3rius deleted the issue-1 branch August 22, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add redis result backend
2 participants