Skip to content

Added redis broker. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2022
Merged

Added redis broker. #5

merged 1 commit into from
Aug 22, 2022

Conversation

chandr-andr
Copy link
Member

@s3rius Please take a look. I wrote some shit. Mb it wiil be good.

@s3rius
Copy link
Member

s3rius commented Aug 14, 2022

image

You need to rebase your branch onto main. As you can see I've changed structure a little bit. Because following PEP-420 sometimes breaks and you cannot import anything from the packages. That's why I changed the structure as for an ordinary package.

I did the same trick for the taskiq-aio-pika package. Please check the structure, before rebasing.

s3rius
s3rius requested changes Aug 14, 2022
View reviewed changes
Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice, but you have to rebase it, and make some chages before merging in the main branch.

@chandr-andr
Copy link
Member Author

@s3rius Check plz, made all changes

s3rius
s3rius approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@s3rius s3rius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@s3rius s3rius merged commit 3402e23 into main Aug 22, 2022
@s3rius s3rius deleted the issue-4 branch August 22, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rius s3rius s3rius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandr-andr @s3rius