Add seconds and milliseconds support in cron_offset #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3rius
reviewed
Jun 20, 2025
taskiq/cli/scheduler/run.py
Outdated
| if task.cron_offset and isinstance(task.cron_offset, timedelta): | ||
| now += task.cron_offset | ||
| additional_seconds += task.cron_offset.seconds + ( |
There was a problem hiding this comment.
Here you use seconds, which might produce unexpected results.
Suggested change
| additional_seconds += task.cron_offset.seconds + ( | |
| additional_seconds += task.cron_offset.total_seconds() + ( |
In this example if you specify minutes and hours it will also correctly work. Or was it implemented like so on purpose?
There was a problem hiding this comment.
There was an even worse mistake here, as you can see. The idea was that additional_seconds is the remainder of the seconds from the entire cron_offset. Now fixed it.
|
this will not work correctly with an update-interval greater than a second |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cron is insensitive to seconds. But cron_offset accepts datetime.timedelta, which has seconds in it. This PR adds sensitivity to seconds and milliseconds from cron_offset.