Update Knockout.js sample to use features from 2.0.0 #48
Conversation
|
@rniemeyer Could you take a look at issue #4 #4 I'd be interested in your opinion on that issue and whether we should continue checking for keycode === 13 or switch to custom bindings. Is this something we could/should do as part of this update to Knockout.js 2.0? |
|
It is a fair point and not hard to implement. We do provide the event object to these handlers for things like this (checking keycode, etc...), but it is cleaner/better for a function on the view model to not be concerned with how it is being called by the view. I'll take care of the changes. |
|
Awesome! I really appreciate it! |
…keycode in the view model - fixes issue #4
… actually add knockout 2.0.0.
Update Knockout.js sample to use features from 2.0.0
|
Great @rniemeyer these changes look good. |
|
@rniemeyer If you could possibly add a "Mark all complete" checkbox, that would be awesome. If not, I'll look into adding it sometime later this week. |
|
@boushley I'll take care of it. Thanks. |
Update Knockout.js sample to use features from 2.0.0
Knockout.js recently released version 2.0.0. Here are a number of updates to the todo example to take advantage of new features in 2.0 and some additional effort to keep the markup as clean and free from logic as possible.
This includes removing the dependency on jQuery Templates (and jQuery itself).