-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use custom binding for knockout.js enter key #4
Comments
Fixed in pull request #48. |
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this issue
Dec 23, 2013
…keycode in the view model - fixes issue tastejs#4
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this issue
Dec 23, 2013
fix checkbox css for IE9, and line-through when checked after an edit of the item
ckirkendall
pushed a commit
to ckirkendall/todomvc
that referenced
this issue
Jan 16, 2014
Keep toggle-all in sync with todos, add parentheses to completed count
ChitoseHibiya
added a commit
to ChitoseHibiya/todomvc
that referenced
this issue
Aug 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it would be more idiomatic Knockout.js code if you set up a custom binding rather than check the keycode in the add function.
The custom binding page in the docs has an example of an event binding under
hasFocus()
. It's jQuery. It might be better for example purposes to use Knockout functions to set up the event.The text was updated successfully, but these errors were encountered: