Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new NSIS windows target #436

Closed
FabianLars opened this issue Apr 12, 2023 · 0 comments · Fixed by #446
Closed

Support new NSIS windows target #436

FabianLars opened this issue Apr 12, 2023 · 0 comments · Fixed by #446
Assignees
@FabianLars
Labels
good first issue Good for newcomers type: feature request New feature or request

Comments

@FabianLars
Copy link
Member

Tauri 1.3 will add a new bundle type on Windows using NSIS. The action should support it asap. Because i want to get #428 merged before that and because i will be mostly out of office the rest of this week, this will likely happen after the 1.3 release -> Opening this issue so people know what's going on if they hit this problem.
@FabianLars FabianLars added type: feature request New feature or request good first issue Good for newcomers labels Apr 12, 2023
@wusyong wusyong assigned wusyong and FabianLars and unassigned wusyong Apr 27, 2023
@FabianLars FabianLars linked a pull request May 2, 2023 that will close this issue
feat: Handle nsis builds, closes #436 #446
Merged
FabianLars added a commit that referenced this issue May 3, 2023
@FabianLars
feat: Handle nsis builds, closes #436 (#446)
0ba09ea 
* feat: Handle nsis builds, closes #435

* handle wix+nsis conflict in updater json

* rebuild dist

* manually convert to bool

* fix nsis updater bundle name

* change file

* reword "Expected artifacts paths", ref #435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FabianLars FabianLars

Labels
good first issue Good for newcomers type: feature request New feature or request
Projects
Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Handle nsis builds, closes #436 tauri-apps/tauri-action
2 participants
@wusyong @FabianLars