Skip to content

Conversation

JonasKruckenberg
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented May 31, 2022

Deploy Preview for tauri ready!

Name Link
🔨 Latest commit 070a7ef
🔍 Latest deploy log https://app.netlify.com/sites/tauri/deploys/62a9db74a575cc0009f0d944
😎 Deploy Preview https://deploy-preview-635--tauri.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JonasKruckenberg JonasKruckenberg marked this pull request as ready for review June 12, 2022 10:00
@JonasKruckenberg
Copy link
Member Author

I'll create screenshots today and then we're good to go I think. Wdyt @lorenzolewis ?

@lorenzolewis
Copy link
Member

I haven't had a chance to check the Vite page, so didn't do any quality/grammar checks on that bit. Let me do that really quick

@lorenzolewis
Copy link
Member

lorenzolewis commented Jun 12, 2022

Just pushed some optimisations. The current issue is that when you have a heading in a fragment, that heading doesn't get rendered in the parent doc's sidebar. Related issue upstream here: facebook/docusaurus#3915. I think this is something we can ignore for now since it only impacts the sidebar and will hopefully be resolved by upstream in the future (it still renders correctly in the body at least)

For the Vite page, could you add what it would look like to call the function in code similar to how I did on the HTML/CSS/JS page?

@lorenzolewis
Copy link
Member

lorenzolewis commented Jun 12, 2022

I also think getting rid of getting-started/README.md and just landing people on the HTML/CSS/JavaScript page would be perfectly acceptable.

@FabianLars
Copy link
Member

FabianLars commented Jun 14, 2022

what do you guys think about swapping out "Global" for "pnpm" in theme/Command.md ? we never mention global installations anywhere and i guess it's somewhat uncommon idk?

@JonasKruckenberg
Copy link
Member Author

what do you guys think about swapping out "Global" for "pnpm" in theme/Command.md ? we never mention global installations anywhere and i guess it's somewhat uncommon idk?

Yeah makes sense to me.

@socket-security
Copy link

Socket Security Report

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

package@version Script field Location
sharp@0.30.6 (added) binding.gyp package.json via @docusaurus/plugin-ideal-image@2.0.0-beta.21
sharp@0.30.6 (added) install package.json via @docusaurus/plugin-ideal-image@2.0.0-beta.21
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

package@version Location
sharp@0.30.6 (added) package.json via @docusaurus/plugin-ideal-image@2.0.0-beta.21
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 2 new install scripts detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ⚠️ 1 new native module detected

Powered by socket.dev

@lorenzolewis lorenzolewis merged commit 19d5c48 into dev Jun 15, 2022
@lorenzolewis lorenzolewis deleted the feat/guides/getting-started branch June 15, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add guide: Tauri + HTML,CSS,JS Add guide: Tauri + Vite
4 participants