Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new msi installers are unable to detect the app with same version already installed on the system. #2211

Closed
Snazzie opened this issue Jul 14, 2021 · 0 comments
Assignees

Comments

@Snazzie
Copy link

Snazzie commented Jul 14, 2021

Describe the bug

New msi installers builds are unaware that the same version of the app its going to install is already installed. Making it possible to continously install duplicate entries of an app when using an installer that has yet to be installed on the machine.

This also introduces another bug where uninstalling duplicate entries causes another app's files to be completely deleted but still visible in programs and features.
The apps content that are were deleted shares a similar name with my app. My app's name is Affinity, other apps name starts with 'Affinity'. (Affinity Designer, Affinity Photo)

To Reproduce

Steps to reproduce the behavior:

duplicate apps

  1. build an msi installer
  2. execute msi installer and install app
  3. build a new msi installer without changing anything
  4. execute new msi installer and install app (same path)
  5. see inside duplicate apps in Control Panel\Programs\Programs and Features

deleting another apps contents

  1. uninstall all duplicate apps
  2. expect Affinity Designer and Affinity Photo to be visible in Control Panel\Programs\Programs and Features. But unable to run as the files contents are deleted.

Expected behavior

Expect new installer to detect that the app with same version is already installed

Screenshots

image

Platform and Versions (required):

Operating System - Windows, version 10.0.22000 X64
Webview2 - 91.0.864.67

Node.js environment
  Node.js - 16.4.2
  @tauri-apps/cli - 1.0.0-beta.5

Global packages
npm 
yarn  1.22.10

Rust environment
rustc 
cargo 

[package]
name = "app"
version = "0.1.0"
description = "A Tauri App"
authors = ["Snazzie"]
license = ""
repository = ""
default-run = "app"
edition = "2018"
build = "src/build.rs"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[profile.release.package.wry]
debug = true
debug-assertions = true

[build-dependencies]
tauri-build = { version = "1.0.0-beta" }

[dependencies]
serde_json = "1.0"
serde = { version = "1.0", features = ["derive"] }
tauri = { git = "https://github.com/tauri-apps/tauri", branch = "dev", features = ["api-all", "system-tray"] }

[features]
default = [ "custom-protocol" ]
custom-protocol = [ "tauri/custom-protocol" ]

{
    "package": {
        "productName": "Affinity",
        "version": "0.1.0"
    },
    "build": {
        "distDir": "../build",
        "devPath": "http://localhost:3000",
        "beforeDevCommand": "npm run start",
        "beforeBuildCommand": "npm run build",
        "withGlobalTauri": true
    },
    "tauri": {
        "bundle": {
            "active": true,
            "targets": "msi",
            "identifier": "com.snazzie.affinity",
            "icon": [
                "icons/32x32.png",
                "icons/128x128.png",
                "icons/128x128@2x.png",
                "icons/icon.icns",
                "icons/icon.ico"
            ],
            "resources": [
                "../bin/Backend"
            ],
            "externalBin": [],
            "copyright": "Copyright © 2021 Aaron Cooper. All rights reserved.",
            "category": "Utility",
            "shortDescription": "The ultimate system utility",
            "longDescription": "",
            "windows": {
                "certificateThumbprint": null,
                "digestAlgorithm": "sha256",
                "timestampUrl": ""
            }
        },
        "systemTray": {
            "iconPath": "icons/icon.png"
        },
        "updater": {
            "active": false
        },
        "allowlist": {
            "all": true,
            "http": {
                "all": true
            }
        },
        "windows": [
            {
                "title": "Affinity",
                "width": 1200,
                "height": 800,
                "minWidth": 1200,
                "minHeight": 800,
                "resizable": true,
                "fullscreen": false,
                "alwaysOnTop": true
            }
        ],
        "security": {
            "csp": "default-src blob: data: filesystem: ws: wss: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'"
        }
    }
}

Stack Trace

@Snazzie Snazzie changed the title new msi installer is unable to detect the app with same version already exists on the system. new msi installers are unable to detect the app with same version already installed on the system. Jul 14, 2021
@lucasfernog lucasfernog self-assigned this Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants